Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Add support for target_precompiled_headers if available #8036

Merged
merged 1 commit into from
Apr 14, 2020
Merged

cmake: Add support for target_precompiled_headers if available #8036

merged 1 commit into from
Apr 14, 2020

Conversation

scribam
Copy link
Contributor

@scribam scribam commented Apr 14, 2020

From cotire's README.md:

The functionality provided by cotire has been superseded by features added to CMake 3.16. Support for pre-compiling and unity builds is now built into CMake. Thus, there will not be any further updates or support for this project.

With CMake 3.16, target_precompile_headers can be used to replace cotire's pre-compiling functionality.

@Nekotekina
Copy link
Member

How to disable precompiled headers then?

@scribam
Copy link
Contributor Author

scribam commented Apr 14, 2020

PR updated. @Nekotekina you can use -DUSE_PRECOMPILED_HEADERS=OFF instead of -DUSE_COTIRE=OFF

-DCMAKE_RANLIB="$RANLIB" \
cmake .. \
-DCMAKE_INSTALL_PREFIX=/usr \
-DBUILD_LLVM_SUBMODULE=OFF -DUSE_PRECOMPILED_HEADERS=OFF \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't you just put this in a new line instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, done

@scribam scribam changed the title cmake: Use target_precompiled_headers if available cmake: Add support for target_precompiled_headers if available Apr 14, 2020
@Nekotekina Nekotekina merged commit 20f53e6 into RPCS3:master Apr 14, 2020
@scribam scribam deleted the cmake-precompiled-headers branch April 14, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants